[VarDumper] Casters for Generator, ReflectionGenerator and ReflectionType #16325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17bd93e to
8dd9601
Compare
8dd9601 to
fe88b9f
Compare
f76f986 to
cf4107c
Compare
|
Status: needs review |
| @@ -18,15 +18,17 @@ | |||
| */ | |||
| class FrameStub extends EnumStub | |||
| { | |||
| public $srcContext; | |||
| const DEFAULT_SRC_CONTEXT = 1; | |||
There was a problem hiding this comment.
I thinking about changing this const to a public static so that the default value can be easily changed
There was a problem hiding this comment.
-1 for a public static. Mutable global state causes issues.
There was a problem hiding this comment.
I still added it because it opens for some flexibility, even if it's global. The component already has some such public static for global configuration. For a dumping tool, that's fine IMO. Default values are overwritable when the default global config is not required.
07b1d8b to
7cbfd8f
Compare
7cbfd8f to
d6c2d75
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 3, 2015
… and ReflectionType (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Casters for Generator, ReflectionGenerator and ReflectionType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I had this on a local branch since a few days: - on PHP7, using ReflectionGenerator allows dumping interesting state info about generators (see test case for example output) - caster for ReflectionType added - source code excerpts are now left-trimmed (see adjusted test cases) Commits ------- d6c2d75 [VarDumper] Casters for Generator, ReflectionGenerator and ReflectionType
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this on a local branch since a few days: