My only concern is how we display the "search icon":

A quick test removing the float: right and just adding a margin-left: 2px would look like this:

@javiereguiluz like you also mentioned in #14110 (comment) ? Think someone just has to make a choice about this, the current implementation seemed to fit your concern quite well back then.

@rvanlaak the most recent comment is only about the location of the icons.

I find the @rvanlaak better. With your proposal @javiereguiluz, you might not see the icon as it is near the text.

Let me know if I still need to change anything.

Hmm, I agree with @javiereguiluz on the location of the search icon.

As we use a borderless table, you would expect everything that belongs to one cell to be somewhat close to eachother. With the float:right;, it's unclear whether the search icon belongs to the information on the left or the right of the icon. As it's closer to the right, I would expect it belongs to the information on the right, but it appears to belong to the info on the left.

I would agree with @wouterj in the case "As we use a borderless table". But the profiler doesn't, right?

I didn't check this PR out locally, so I gave feedback based on @javiereguiluz's screenshot and it appears to be borderless in those screenshots. If it isn't, I agree that floating right is nicer.

@wouterj this is how both proposals look on my computer (I've forced all icons to be displayed to get the whole picture):

@rvanlaak's proposal:

My proposal:

Oh, I did remember to have vertical lines while developing it as well but that probably still was the 2.7 branch. Removing the float in this case seems like the best solution. Your latest comment doesn't include the hover @javiereguiluz , you mean your proposal as in #16344 (comment) ?

So two options:

1. Remove the float from the icon
2. Let the vertical table borders return, and keep the right float so it is a bit more clear if near text (as @fabpot mentions)

@rvanlaak in the new profiler design, columns don't have vertical borders (only rows have horizontal borders). I'd prefer not to change this design feature (it would take us a lot of time to tweak everything and other projects are already using this design. Example: opensoftwareconsulting/deprecation-detector#58 (comment)).

I'm fine with any of the options, but I don't think I should make the decision about it. 👍 So shall we get rid of the float?

I now agree with @javiereguiluz reasoning, let's do that.

Fixed 👍

Thank you @rvanlaak.