Add the PHP 7 polyfill for the random_bytes function #16365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,8 @@ | |||
| "php": ">=5.3.9", | |||
| "symfony/security": "~2.8|~3.0.0", | |||
| "symfony/security-acl": "~2.7|~3.0.0", | |||
| "symfony/http-kernel": "~2.2|~3.0.0" | |||
| "symfony/http-kernel": "~2.2|~3.0.0", | |||
| "symfony/polyfill-php70": "~1.0" | |||
There was a problem hiding this comment.
This is not needed. We don't call any of the random functions directly in the SecurityBundle.
There was a problem hiding this comment.
It is called in UserPasswordEncoderCommand.php#L167
|
Status: Needs work |
|
👍 Status: Reviewed |
| @@ -19,6 +19,7 @@ | |||
| "php": ">=5.3.9", | |||
| "symfony/polyfill-php55": "~1.0", | |||
| "symfony/polyfill-php56": "~1.0", | |||
| "symfony/polyfill-php70": "~1.0", | |||
There was a problem hiding this comment.
this one needs to be removed in 3.0 as its only there for the deprecated SecureRandom class
|
👍 |
|
Thank you @pierredup. |
Tobion
added a commit
that referenced
this pull request
Oct 29, 2015
…redup) This PR was merged into the 2.8 branch. Discussion ---------- Add the PHP 7 polyfill for the random_bytes function | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Some classes (like the `SecureRandom` class) currently depends on the `random_bytes` function, which is only available in the PHP 7 polyfill Commits ------- 8ab8ca0 Add the PHP 7 polyfill for the random_bytes function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some classes (like the
SecureRandomclass) currently depends on therandom_bytesfunction, which is only available in the PHP 7 polyfill