Skip to content

[Routing] fix docblock description for the build() method #16374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2015
Merged

[Routing] fix docblock description for the build() method #16374

merged 1 commit into from
Oct 29, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 28, 2015

Q A
Fixed tickets #15778
License MIT

Tobion
Tobion reviewed Oct 29, 2015
View reviewed changes
src/Symfony/Component/Routing/RouteCollectionBuilder.php
@@ -238,7 +238,7 @@ public function setMethods($methods)
}

/**
* Creates the final ArrayCollection, returns it, and clears everything.
* Creates the final RouteCollection, returns it, and clears everything.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "clears everything" mean? Doesnt look like it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, that part should probably be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@xabbuh xabbuh changed the title [Routing] fix class name in docblock [Routing] fix docblock description for the build() method Oct 29, 2015
@fabpot
Copy link
Member

fabpot commented Oct 29, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit ca32ed4 into symfony:2.8 Oct 29, 2015
fabpot added a commit that referenced this pull request Oct 29, 2015
@fabpot
minor #16374 [Routing] fix docblock description for the build() metho…
e2022ce 
…d (xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[Routing] fix docblock description for the build() method

| Q             | A
| ------------- | ---
| Fixed tickets | #15778
| License       | MIT

Commits
-------

ca32ed4 fix docblock description for the build() method
@xabbuh xabbuh deleted the pr-15778-tweak branch October 29, 2015 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @Tobion @carsonbot