[WebProfilerBundle] Fix minitoolbar height #16377
Conversation
|
I remember some related issue reported by a user of the Safari browser. Have you tested this change in Chrome, Firefox and Safari? Thanks! |
|
From left to right: Edge, Edge (minimized), Chrome 46, Chrome 46 (minimized), FF41, FF41 (minimized)
So Webkit and Gecko are fine. Let's see or I can make another PR to fix Edge later today |
|
This is how I see the minimized toolbar in Safari: Before (it was slightly wrong)
After this change (it's a bit worse)
|
5b05c03 to
a4550c3
Compare
|
Didn't have a Safari environment available right now, did hope they'd respect webkit ;) The anchor needs |
|
No luck with the latest changes. However, if I make this change: .sf-minitoolbar {
- padding: 6px 6px 0;
+ padding: 4px 6px 0;
}The problem is fixed in Safari:
|
|
Mmh, that also doesn't really seem squarish, let me get back to you after I've solved this 👍 |
|
@rvanlaak Any news? |
|
Wasn't able to find a Mac to fix this so far, and the latest Safari for Windows is a bit old for testing right? |
|
@rvanlaak yeah, safari on windows is not relevant |
a4550c3 to
fed9108
Compare
fed9108 to
0459912
Compare
|
Updated + rebased, this should do the trick for both Edge and Safari |
|
Yes, this fixes #16597 for IE11 and Edge. Also see #16377 (comment) |
|
Thank you @rvanlaak. |
This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Fix minitoolbar height | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The height of the minimized toolbar icon was a bit off. This change makes sure the icon has the same height as the toolbar itself. Commits ------- 0459912 [WebProfilerBundle] Fix minitoolbar height
The height of the minimized toolbar icon was a bit off. This change makes sure the icon has the same height as the toolbar itself.