-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
remove polyfills for unsupported php versions #16381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
} | ||
], | ||
"require": { | ||
"php": ">=5.3.9" | ||
"php": ">=5.5.9" | ||
}, | ||
"suggest": { | ||
"symfony/http-foundation": "" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,7 @@ | |
], | ||
"require": { | ||
"php": ">=5.5.9", | ||
"symfony/polyfill-php55": "~1.0", | ||
"symfony/polyfill-php56": "~1.0", | ||
"symfony/polyfill-php70": "~1.0", | ||
"symfony/polyfill-util": "~1.0" | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
"require-dev": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,11 +20,10 @@ | |
"symfony/event-dispatcher": "~2.8|~3.0", | ||
"symfony/http-foundation": "~2.8|~3.0", | ||
"symfony/http-kernel": "~2.8|~3.0", | ||
"symfony/polyfill-php55": "~1.0", | ||
"symfony/polyfill-php56": "~1.0", | ||
"symfony/polyfill-php70": "~1.0", | ||
"symfony/polyfill-util": "~1.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. extra coma on the line below (as reported by fabbot) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
"symfony/property-access": "~2.8|~3.0", | ||
"symfony/property-access": "~2.8|~3.0" | ||
}, | ||
"replace": { | ||
"symfony/security-core": "self.version", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should even be changed in 2.7/2.8 to 5.3.9, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done and rebased