[FrameworkBundle][Form] Better exception message for private form tagged services #16419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a feature, this is simply a better error message which imo falls under a bug-fix. This could in theory even be merged back into 2.3 and would also be valuable in 2.7. |
|
👍 a very nice error message improvement |
|
That's not just about a better error message but a change in behavior, so that's for 2.8. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2015
…rivate form tagged services (ogizanagi) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][Form] Better exception message for private form tagged services | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Similar to what is done in [RegisterListenerPass](https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php#L61-L63), those changes allow to have a better exception message when defining a private `form.type`, `form.type_extension` or `form.form_guesser` tagged service, and at container compilation instead of runtime: > The service "my.form.type" must be public as form types are lazy-loaded. instead of: > You have requested a non-existent service "my.form.type" If I'm right, similar cases were considered as new features in the past, so this targets 2.8. Commits ------- 11d675f [FrameworkBundle][Form] Better exception message for private form tagged services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what is done in RegisterListenerPass, those changes allow to have a better exception message when defining a private
form.type,form.type_extensionorform.form_guessertagged service, and at container compilation instead of runtime:instead of:
If I'm right, similar cases were considered as new features in the past, so this targets 2.8.