[Serializer] GetSetNormalizer shouldn't set/get static methods #16454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 It's why it would be nice to optimize performance of PropertyAccess component: it will allow to deprecate all normalizers except |
|
@dunglas I'm not sure I agree with that since PropertyNormalizer and GetSetNormalizer are more limited in scope then ProperyAccess and sometimes that's exactly what I want 😄 |
|
Status: Reviewed |
|
I've introduced this cache system in the PropertyAccess component. It's why having a single normalizer relying on this component can enhance global performance and ease the maintenance. |
|
Thank you @boekkooi. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2015
…hods (boekkooi) This PR was merged into the 2.7 branch. Discussion ---------- [Serializer] GetSetNormalizer shouldn't set/get static methods | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | maybe | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR fixes setting static getters and setters when serializing. This is strictly speaking a BC break but in my opinion a needed one because the current behavior is unexpected. Commits ------- d8d4405 [Serializer] GetSetNormalizer shouldn't set/get static methods
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes setting static getters and setters when serializing.
This is strictly speaking a BC break but in my opinion a needed one because the current behavior is unexpected.