[PropertyAccess] Fix dynamic property accessing. #16462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add a test covering this |
|
@stof some tests exist in 2.7 (it's how I've found I've broke things). I'll backport them ASAP but I've opened this PR right now because 2.3 is currently buggy. |
|
well, this PR is the one where backporting makes sense, as the backport is adding the test preventing this regression |
|
Test added |
|
AppVeyor failures look unrelated. |
|
👍 |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [PropertyAccess] Fix dynamic property accessing. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Fix a bug regarding dynamic properties access introduced by #16294. Commits ------- 916f9e0 [PropertyAccess] Test access to dynamic properties 352dfb9 [PropertyAccess] Fix dynamic property accessing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug regarding dynamic properties access introduced by #16294.