[HttpKernel] Keep 3.0 compat by not using ContainerAware #16466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 4, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
cb89014 to
ed29c03
Compare
| @@ -24,9 +24,9 @@ | |||
| protected $container; | |||
|
|
|||
| /** | |||
| * Sets the Container associated with this Controller. | |||
| * Sets the Container. | |||
There was a problem hiding this comment.
can you lowercase container please as it doesnt mean a class but a concept.
There was a problem hiding this comment.
and these changes should be done in 2.7
ed29c03 to
31a0669
Compare
|
Comments addressed |
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 4, 2015
… (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpKernel] Keep 3.0 compat by not using ContainerAware | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 31a0669 [HttpKernel] Keep 3.0 compat by not using ContainerAware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.