-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security] Remove dependency on security-core from security-csrf #16494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enumag
commented
Nov 7, 2015
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | possibly |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #15872 |
License | MIT |
Doc PR |
This cannot be done in 2.8 as it's a BC break and also doesn't make sense in 2.8 as one of the main classes (UriSafeTokenGenerator) still depends on |
That's fine by me. If you want me to create new PR against the 3.0 branch let me know. The change in the exception might cause BC break if somebody was catching it using the parent exception or ExceptionInterface from Securty/Core. Not sure how bad it is to make this change but it would be sad to have a dependency only because of an exception. |
@Tobion Actually I think the dependency in UriSafeTokenGenerator is not relevant. If the interface doesn't exist, the UriSafeTokenGenerator should still work fine. |
Closing as we don't break BC in stable versions and we can't add new classes/exceptions. |
@fabpot Would it be possible to do this for 4.0? |
@enumag It is for 3.4 (next minor release), could you rebase and update the PR target branch accordingly? There is no more BC break, reopening. |
@chalasr why is there no bc break anymore? The exception hierarchy will still be changed in a BC break way. |
I also think this is in line with the Symfony flex |
It's still a bc break, so this interface hierarchy change can't be done in steps left to do here:
status: needs work |
@ostrolucky deprecating would not help here, RuntimeException especially. Triggering a notice when the exception is caught is not possible, and would not be enough anyway as one might catch After all I think it's not worth it, re-closing, sorry for the noise. |