[Bridge\PhpUnit] Add extra clock-mocked namespaces in phpunit.xml.dist #16502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Nov 9, 2015
…phpunit.xml.dist (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [Bridge\PhpUnit] Add extra clock-mocked namespaces in phpunit.xml.dist | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This fixes the currently failing tests on travis by: - checking for class existence before checking for groups, recursively now, when loading `@group time-sensitive` annotations - allow specifying extra clock-mocked namespaces in phpunit.xml files, required e.g. when HttpKernel is tested standalone and requires clock-mocks to be enabled for the HttpFoundation namespace. Commits ------- cd36c07 [Bridge\PhpUnit] Add extra clock-mocked namespaces in phpunit.xml.dist
| } | ||
| } | ||
| if (self::$globallyEnabled) { | ||
| $this->state = -2; |
There was a problem hiding this comment.
Would be nice to define these states as constants so others could understand what they mean ;)
There was a problem hiding this comment.
but this is private internal details, and constants are public... and giving a name is hard :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the currently failing tests on travis by:
@group time-sensitiveannotations