[2.3][Process] fix Proccess run with pts enabled #16510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ewgRa
commented
Nov 10, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #12643 |
| License | MIT |
| Doc PR |
|
When fabbot.io patch is applied, there is a conflicts, I think better to merge it without conflicts. |
|
Test failure seems not related to this PR |
|
|
||
| if (!$this->useFileHandles && $this->enhanceSigchildCompatibility && $this->isSigchildEnabled()) { | ||
| // Workaround for the bug, when PTS functionality is enabled. | ||
| // @see : https://github.com/symfony/symfony/issues/12643 |
There was a problem hiding this comment.
no need to ref this one in the code
|
@ewgRa could you please fabbot's issues also (even if unrelated to your change)? |
|
See #12643 (comment) for some background on why this works |
|
👍 (after rebasing) |
|
done, anything else? |
|
Thank you @ewgRa. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 10, 2015
This PR was squashed before being merged into the 2.3 branch (closes #16510). Discussion ---------- [2.3][Process] fix Proccess run with pts enabled | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12643 | License | MIT | Doc PR | Commits ------- 9cf90fb [2.3][Process] fix Proccess run with pts enabled
|
Closed via ab3c8f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.