[Process] Fix PhpProcess with phpdbg runtime #16574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->assertFalse($process->hasBeenSignaled()); | ||
| } | ||
|
|
||
| public function testProcessWithoutTermSignalIsNotSignaled() |
There was a problem hiding this comment.
why are you removing these tests ?
There was a problem hiding this comment.
they are exact duplicates if I did not make any mistake. And I moved the only assertion in the below test.
There was a problem hiding this comment.
they are not, because of overwrites changing the behavior of some tests based on sigchild being enabled (see child classes). hasBeenSignaled and getTermSignal need to be tested separately to handle these cases properly.
There was a problem hiding this comment.
ok, reverted, thanks for checking
107fd3e to
7a97093
Compare
| @@ -49,7 +52,6 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit") || md5_file(__ | |||
| $zip->close(); | |||
| chdir("phpunit-$PHPUNIT_VERSION"); | |||
| passthru("$COMPOSER remove --no-update symfony/yaml"); | |||
| passthru("$COMPOSER require --no-update phpunit/phpunit-mock-objects \"<=3.0.0\""); | |||
There was a problem hiding this comment.
phpunit-mock-objects 3.0.4 fixes the issue we had
7a97093 to
9669238
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 18, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [Process] Fix PhpProcess with phpdbg runtime | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - With this PR, I'm able to successfully run the test suite of the Process component using `phpdbg -qrr ./phpunit src/Symfony/Component/Process/` Commits ------- 9669238 [Process] Fix PhpProcess with phpdbg runtime
nicolas-grekas
added a commit
that referenced
this pull request
Oct 29, 2023
…ality is enabled (a.dmitryuk) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Process] remove fixing of legacy bug, when PTS functionality is enabled | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT The PR drop fixing PHP bug, that was closed in PHP 7.0 Original issues: php/php-src#1588 #16574 Original commit: php/php-src@ff6b309 Commits ------- 03590f1 [Process] remove fixing of legacy bug, when PTS functionality is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I'm able to successfully run the test suite of the Process component using
phpdbg -qrr ./phpunit src/Symfony/Component/Process/