-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Remove deprecated class method parameter #16629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpFoundation] Remove deprecated class method parameter #16629
Conversation
Good catch. Can you first submit a PR on 2.8 to generate deprecation notices when a call to these methods uses |
@fabpot I'll do it this Wednesday |
I don't think we need deprecation message for those methods because it calls But we need to trigger a deprecation message for |
@Tobion
but check if $filter is a boolean ($deep) or an integer (right $filter)? |
Yes. Basically change the signature to the new one: |
Sorry for the late response |
Will need to be rebased once #16706 is merged |
Thank you @belka-ew. |
…ter (belka-ew) This PR was merged into the 3.0-dev branch. Discussion ---------- [HttpFoundation] Remove deprecated class method parameter | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | $deep argument in Symfony\Component\HttpFoundation\BagParameter::get was deprecated in 2.8 and removed in master, but it is still used in the code of the class (and in the filter() method) Commits ------- 4ffe14c [HttpFoundation] Remove deprecated class method parameter
$deep argument in Symfony\Component\HttpFoundation\BagParameter::get was deprecated in 2.8 and removed in master, but it is still used in the code of the class (and in the filter() method)