Updated type guessers to use the PHP 5.5 ::class constant #16648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, Symfony 3.0 supports 5.5. |
|
Fortunately, |
|
I've updated the title :) |
|
This would make it harder to merge branches together during the Symfony 2.8 lifetime though, as it would create conflicts. So I'm not sure we should do it yet. There is no real added value for this PR compared to the drawbacks for maintainers (this is why we don't use the short array syntax in the 3.0 codebase btw). |
|
I agree with @stof, I does not add any "value" to the framework and it would make the core team life harder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost same PR as #16334, but with
::classconstants.