Skip to content

[Yaml] sync changelog and upgrade files #16654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2015
Merged

[Yaml] sync changelog and upgrade files #16654

merged 1 commit into from
Nov 25, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 24, 2015

Q A
Fixed tickets #16433
License MIT

@xabbuh xabbuh mentioned this pull request Nov 24, 2015
Merged
wouterj
wouterj reviewed Nov 24, 2015
View reviewed changes
UPGRADE-2.8.md
----

* Deprecated usage of a colon in an unquoted mapping value
* Deprecated usage of `@`, `\``, `|`, and `>` at the beginning of an unquoted string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error. You should use \`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed it

@xabbuh xabbuh force-pushed the pr-16433-upgrade branch 2 times, most recently from 242e47c to e184cea Compare November 24, 2015 21:03
@fabpot
Copy link
Member

fabpot commented Nov 25, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 062d707 into symfony:2.8 Nov 25, 2015
fabpot added a commit that referenced this pull request Nov 25, 2015
@fabpot
minor #16654 [Yaml] sync changelog and upgrade files (xabbuh)
8b58291 
This PR was merged into the 2.8 branch.

Discussion
----------

[Yaml] sync changelog and upgrade files

| Q             | A
| ------------- | ---
| Fixed tickets | #16433
| License       | MIT

Commits
-------

062d707 [Yaml] sync changelog and upgrade files
@xabbuh xabbuh deleted the pr-16433-upgrade branch November 25, 2015 06:54
stof
stof reviewed Nov 25, 2015
View reviewed changes
UPGRADE-2.8.md
* Deprecated usage of a colon in an unquoted mapping value
* Deprecated usage of `@`, `` ` ``, `|`, and `>` at the beginning of an unquoted string
* Deprecated non-escaped \ in double-quoted strings when parsing Yaml
("Foo\Var" is not valid whereas "Foo\\Var" is)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should enclose these Yaml strings in backticks to make them code blocks (otherwise the double backslash will not appear as it will be considered as a markdown escaping)

@xabbuh xabbuh restored the pr-16433-upgrade branch November 25, 2015 09:43
@xabbuh xabbuh deleted the pr-16433-upgrade branch November 25, 2015 12:40
@xabbuh xabbuh mentioned this pull request Nov 25, 2015
Merged
fabpot added a commit that referenced this pull request Nov 28, 2015
@fabpot
minor #16662 [Yaml] more fixes to changelog and upgrade files (Christ…
0627979 
…ian Flothmann)

This PR was merged into the 2.8 branch.

Discussion
----------

[Yaml] more fixes to changelog and upgrade files

| Q             | A
| ------------- | ---
| Fixed tickets | #16433, #16654
| License       | MIT

Commits
-------

273ed25 [Yaml] more fixes to changelog and upgrade files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @stof @wouterj @carsonbot