Skip to content

[Form] Disabled view data validation if "data_class" is set to null #16679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2015

Conversation

webmozart
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14877
License MIT
Doc PR -

After this PR, Form::setData() does not validate the view data anymore when "data_class" is set to null. This way it is possible to create fields with dynamic view data types (see #14877).

@nicolas-grekas
Copy link
Member

👍 (failures not related)

@Tobion
Copy link
Contributor

Tobion commented Nov 26, 2015

👍

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Nov 26, 2015

Thank you @webmozart.

@fabpot fabpot merged commit f495410 into symfony:2.7 Nov 26, 2015
fabpot added a commit that referenced this pull request Nov 26, 2015
…t to null (webmozart)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Disabled view data validation if "data_class" is set to null

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14877
| License       | MIT
| Doc PR        | -

After this PR, Form::setData() does not validate the view data anymore when "data_class" is set to `null`. This way it is possible to create fields with dynamic view data types (see #14877).

Commits
-------

f495410 [Form] Disabled view data validation if "data_class" is set to null
This was referenced Nov 30, 2015
@fabpot fabpot mentioned this pull request Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants