[Security] remove deprecated HTTP digest auth key #16719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 28, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -78,7 +78,7 @@ public function handle(GetResponseEvent $event) | |||
| } | |||
|
|
|||
| try { | |||
| $digestAuth->validateAndDecode($this->authenticationEntryPoint->getKey(), $this->authenticationEntryPoint->getRealmName()); | |||
| $digestAuth->validateAndDecode($this->authenticationEntryPoint->getSecret(), $this->authenticationEntryPoint->getRealmName()); | |||
There was a problem hiding this comment.
We do not seem to have tests covering this. But they would need to be added in older versions.
There was a problem hiding this comment.
and we should make this change on 2.8 as well, right?
|
👍 Status: reviewed |
|
Looks like we should remove the config option for this in the SecurityBundle too. |
d47b2d0 to
812396d
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 28, 2015
…buh) This PR was merged into the 3.0-dev branch. Discussion ---------- [Security] remove deprecated HTTP digest auth key | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 812396d [Security] remove deprecated HTTP digest auth key
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.