[Console][ProgressBar] redrawFrequency should never be 0 #16742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR! Maybe I would add explicit test to cover the change in behavior of |
|
👍 But please add a test
There cannot be a test for this. Otherwise it would fail. |
ecdcaab to
368423b
Compare
|
Added tests and rebased against the newest 2.8 branch. |
| public function testRedrawFrequencyIsAtLeastOneIfZeroGiven() | ||
| { | ||
| $bar = $this->getMock('Symfony\Component\Console\Helper\ProgressBar', array('display'), | ||
| array($output = $this->getOutputStream(), 6)); |
There was a problem hiding this comment.
should be on one line to be consistent
There was a problem hiding this comment.
and $output is not used. please remove the var in testRedrawFrequency and testRedrawFrequencyIsAtLeastOneIfSmallerOneGiven as well
…se produce an error.
368423b to
6a0a811
Compare
|
@Tobion All done. :) |
|
👍 Should be merged in 2.7 Status: Reviewed |
|
Thank you @dritter. |
This was referenced Dec 26, 2015
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the redraw frequency at least to 1. Setting it to 0 would otherwise produce a "division by zero" error.
why?
I had a piece of code that used a ProgressBar and set the redraw frequency to a calculated value. In some cases this calculated value was 0 (or just smaller than 1, internally a cast to
intis made). In thesetProgressthe redraw frequency is used for a calculation of the period. There the error happens (and shows that redraw frequency should never be 0).Ticket
There is no ticket concerning this issue. I could do one, if you want.
Tests
This gets tested implicitly in
ProgressBarTest::testNonDecoratedOutputWithoutMax.