[Process] Fix signaling/stopping logic on Windows #16753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 30, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
0edc997 to
7152384
Compare
| } | ||
| // avoid exception here : | ||
| // process is supposed to be running, but it might have stop | ||
| // just after this line. |
There was a problem hiding this comment.
(existing typo) "but it might have stopped just after this line."
5ef6b5c to
2b672f4
Compare
| $this->doSignal($signal ?: SIGKILL, false); | ||
| } | ||
| // Avoid exception here: process is supposed to be running, but it might have stopped just | ||
| // after this line. In any case, let's silently discard the error, we can not do anything. |
2b672f4 to
8012731
Compare
8012731 to
9afbea2
Compare
|
Yeeah, tests are green on appveyor! |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2015
…-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Process] Fix signaling/stopping logic on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9afbea2 [Process] Fix signaling/stopping logic on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.