[PhpUnitBridge] Add weak-verbose mode and match against message instead of test name #16789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| suite once a deprecation is triggered by the `MyTest::testMethod` test. | ||
| In case you need to inspect the stack trace of a particular deprecation triggered | ||
| by your unit tests, you can set the `SYMFONY_DEPRECATIONS_HELPER` env var to a | ||
| regexp that matches this depreaction's message. For example, |
There was a problem hiding this comment.
typo: depreaction's -> deprecation's
026b8b7 to
62b3eff
Compare
|
typos fixed, thanks |
62b3eff to
c27975d
Compare
| @@ -64,7 +64,7 @@ public static function register($mode = false) | |||
| $group = 'remaining'; | |||
| } | |||
|
|
|||
| if (isset($mode[0]) && '/' === $mode[0] && preg_match($mode, $class.'::'.$method)) { | |||
| if (isset($mode[0]) && '/' === $mode[0] && preg_match($mode, $msg)) { | |||
There was a problem hiding this comment.
I don't understand why this preg_match is there. Is it an undocumented feature of the helper ?
c27975d to
cea79d1
Compare
|
👍 |
1 similar comment
|
👍 |
| @@ -144,7 +144,7 @@ public static function register($mode = false) | |||
| if (!empty($notices)) { | |||
| echo "\n"; | |||
| } | |||
| if ('weak' !== $mode && ($deprecations['unsilenced'] || $deprecations['remaining'] || $deprecations['other'])) { | |||
| if ('weak' !== $mode && 'weak-verbose' !== $mode && ($deprecations['unsilenced'] || $deprecations['remaining'] || $deprecations['other'])) { | |||
There was a problem hiding this comment.
we should add those strings as constants esp. since $mode is part of the public api
cea79d1 to
a670ff1
Compare
|
👍 |
|
Thank you @nicolas-grekas. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
…t message instead of test name (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14475 | License | MIT | Doc PR | - This is double a DX bug fix: - the weak-verbose allows showing messages but exit with 0 (see #14475) - matching against $class::$method was a mistake of mine: you can already `--filter` in phpunit to get by-test filtering but you can't select which message should be traced without this change. I stumbled upon this limitation while doing a Symfony 3 migration workshop... Commits ------- a670ff1 [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name
nicolas-grekas
added a commit
that referenced
this pull request
Dec 11, 2015
…s upper bound" mode (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16789, #14475 | License | MIT | Doc PR | - This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See #16789. It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step. ping @wouterj @Tobion @craue @fabpot @stof Commits ------- 58cd3ee [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is double a DX bug fix:
--filterin phpunit to get by-test filtering but you can't select which message should be traced without this change. I stumbled upon this limitation while doing a Symfony 3 migration workshop...