Improve error message for undefined DIC aliases #16799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, I think the arguments need to be the other way round (`templating` is an alias pointing to `templating.engine.twig`).
| @@ -45,7 +45,7 @@ public function process(ContainerBuilder $container) | |||
| try { | |||
| $definition = $container->getDefinition($aliasId); | |||
| } catch (InvalidArgumentException $e) { | |||
| throw new InvalidArgumentException(sprintf('Unable to replace alias "%s" with "%s".', $alias, $id), null, $e); | |||
| throw new InvalidArgumentException(sprintf('Unable to replace alias name "%s" with actual definition "%s".', $id, $alias), null, $e); | |||
There was a problem hiding this comment.
"name" is a bit redundant here, alias already implies the name.
|
Thanks for fixing this bug @mpdude. |
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I think the arguments need to be the other way round (
templatingis an alias pointing totemplating.engine.twig).