[Process] Fix stopping a process on Windows #16813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 2, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15617 |
| License | MIT |
| Doc PR | - |
|
Is the HHVM failure in the process component test related to the change you made here ? |
|
HHVM failure is unrelated, it would need an other fix |
| @@ -838,10 +860,10 @@ public function testMethodsThatNeedATerminatedProcess($method) | |||
| $process->stop(0); | |||
| $this->fail('A LogicException must have been thrown'); | |||
There was a problem hiding this comment.
These fail conditions in the tests you changed are now useless pretty much. So they can be removed.
There was a problem hiding this comment.
not sure: throw $e still needs $e to be defined
There was a problem hiding this comment.
I see. Those tests should be rewritten with try...finally in 3.0
| usleep(1000); | ||
| } | ||
|
|
||
| // Don't call ->stop() nor ->close() since it's blocking and we don't care about waiting for the subprocess here |
There was a problem hiding this comment.
calling for review/comments on this change
|
Thank you @nicolas-grekas. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
…kas) This PR was merged into the 2.3 branch. Discussion ---------- [Process] Fix stopping a process on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15617 | License | MIT | Doc PR | - Commits ------- 80fb51c [Process] Fix stopping a process on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.