[VarDumper] fix .sf-dump z-index (debug bar conflict) #16825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, doesn't work for me either. |
|
It doesn't work on chrome. It does work in firefox though.
|
|
99998 Still shows the dump over the bar in Chrome |
|
Doesn't work for me on Chrome. |
|
after some investigation it's related to webkit animation that cause the animated element to ignore z-index behavior. (reports in chromium track : https://code.google.com/p/chromium/issues/detail?id=501596) so PR if fine. 👍 |
|
👍 |
|
👍 as bug fix on 2.7 |
|
Thank you @monsty. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
…oine LA) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #16825). Discussion ---------- [VarDumper] fix .sf-dump z-index (debug bar conflict) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16824 | License | MIT | Doc PR | - Just changed the z-index because the twig dump is actually displaying over the debug bar (#16824). Commits ------- a72efb9 [VarDumper] fixed .sf-dump z-index
|
Why is the z-index needed there? Removing the z-index property (for pre.sf-dump) at all the issue seems to be solved both in Chrome and Firefox... |
This was referenced Dec 26, 2015
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changed the z-index because the twig dump is actually displaying over the debug bar (#16824).