[Ldap] Escape carriage returns in LDAP DNs. #16842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use Symfony\Component\Ldap\LdapClient; | ||
| use Symfony\Polyfill\Php56\Php56 as p; | ||
|
|
||
| class LdapClientTest extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
You should skip the test if the extension is not enabled, which is the case in one of the two Appveyor builds (one is run with the extension, the other without).
|
I adjusted the test to require the LDAP extension. Seems to have appeased Appveyor anyway. |
|
LGTM 👍 |
|
Thank you @ChadSikorra. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2015
This PR was squashed before being merged into the 2.8 branch (closes #16842). Discussion ---------- [Ldap] Escape carriage returns in LDAP DNs. Depends upon this commit in polyfill: symfony/polyfill#14 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Carriage returns are supposed to be escaped in a LDAP DN. Leading and trailing spaces should be encoded as well. The spaces were taken care of in the polyfill implementation of `ldap_escape`, but the actual PHP function doesn't do the same. So I moved that logic within the component function and removed it from the polyfill function. Commits ------- 2243db4 [Ldap] Escape carriage returns in LDAP DNs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends upon this commit in polyfill: symfony/polyfill#14
Carriage returns are supposed to be escaped in a LDAP DN. Leading and trailing spaces should be encoded as well. The spaces were taken care of in the polyfill implementation of
ldap_escape, but the actual PHP function doesn't do the same. So I moved that logic within the component function and removed it from the polyfill function.