[DX] [PropertyInfo] Filter PropertyInfo Extractors with Interfaces #16890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single service tag to filter a central source of information extractor instances. Since PropertyInfo requires PHP 5.5+, use ::class constant to negate the use of class constants or strings.
|
It is not possible because it doesn't handle every use cases, see #15858 (comment) and my reply for details. |
|
You're absolutely right, I didn't take into account different ordering for different types. |
|
But as you're the second person asking why after @fabpot, it can be a good idea to mention it in the doc :-) |
|
I'll update the documentation PR to include the explanation in your comment, since it's an important but not immediately obvious decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve developer experience, require just one collection of extractors that filters by the interfaces that have been implemented on each extractor.
However, this does break backwards-compatibility for:
PropertyInfoExtractor.PropertyInfoExtractor.property_info.*_extractortags.I'm suggesting this change purely in the unlikely event that the PropertyInfo component can be classed as internal, since documentation is still pending.
/cc @dunglas