[FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 #16922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlmogBaku
commented
Dec 9, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16920 |
| License | MIT |
| $options['output'] = $output; | ||
| $helper->describe($output, $object, $options); | ||
| $options['output'] = $io; | ||
| $helper->describe($io, $object, $options); |
There was a problem hiding this comment.
This should probably be reverted, the helper need the Output instance.
| @@ -126,7 +126,7 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $builder->setTimeout(null); | |||
| $process = $builder->getProcess(); | |||
|
|
|||
| if (OutputInterface::VERBOSITY_VERBOSE > $output->getVerbosity()) { | |||
There was a problem hiding this comment.
This one should probably be left as $output->getVerbosity()
There was a problem hiding this comment.
You are probably right. Using the original object will give better performance than the wrapped one.
DONE
|
Good catch, thanks @AlmogBaku. |
Tobion
added a commit
that referenced
this pull request
Dec 9, 2015
…lmogBaku) This PR was squashed before being merged into the 2.8 branch (closes #16922). Discussion ---------- [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 | Q | A | ------------- | --- | Bug fix? | **yes** | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | **yes** | Fixed tickets | #16920 | License | MIT Commits ------- d2b9a1d [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.