Skip to content

CSS min-height and min-width should not be "auto" #16964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

aschempp
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Setting min-width and min-height to auto does not work in Safari and IE. The auto property has been removed from the standard meanwhile (see https://developer.mozilla.org/en-US/docs/Web/CSS/min-height).

Correct is to set a minimum of zero, which is actually "no minimum height".

This is what the web profiler looks like before and after on latest Safari:

bildschirmfoto 2015-12-11 um 11 02 31

bildschirmfoto 2015-12-11 um 11 02 25

@javiereguiluz
Copy link
Member

I can confirm the bug and that the solution provided by @aschempp solves the problem in all browsers. Thanks!

@nicolas-grekas
Copy link
Member

Thank you @aschempp.

@nicolas-grekas nicolas-grekas merged commit 107c44a into symfony:2.8 Dec 18, 2015
nicolas-grekas added a commit that referenced this pull request Dec 18, 2015
This PR was merged into the 2.8 branch.

Discussion
----------

CSS min-height and min-width should not be "auto"

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Setting `min-width` and `min-height` to `auto` does not work in Safari and IE. The `auto` property has been removed from the standard meanwhile (see https://developer.mozilla.org/en-US/docs/Web/CSS/min-height).

Correct is to set a minimum of zero, which is actually "no minimum height".

This is what the web profiler looks like before and after on latest Safari:

![bildschirmfoto 2015-12-11 um 11 02 31](https://cloud.githubusercontent.com/assets/1073273/11741083/f17357fc-9ff6-11e5-8b59-239b38d37b2a.png)

![bildschirmfoto 2015-12-11 um 11 02 25](https://cloud.githubusercontent.com/assets/1073273/11741089/f6fb6656-9ff6-11e5-946f-f6c9f936c17f.png)

Commits
-------

107c44a CSS min-height and min-width should not be "auto"
This was referenced Dec 26, 2015
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
…aschempp)

This PR was merged into the 2.8 branch.

Discussion
----------

CSS min-height and min-width should not be "auto"

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Setting `min-width` and `min-height` to `auto` does not work in Safari and IE. The `auto` property has been removed from the standard meanwhile (see https://developer.mozilla.org/en-US/docs/Web/CSS/min-height).

Correct is to set a minimum of zero, which is actually "no minimum height".

This is what the web profiler looks like before and after on latest Safari:

![bildschirmfoto 2015-12-11 um 11 02 31](https://cloud.githubusercontent.com/assets/1073273/11741083/f17357fc-9ff6-11e5-8b59-239b38d37b2a.png)

![bildschirmfoto 2015-12-11 um 11 02 25](https://cloud.githubusercontent.com/assets/1073273/11741089/f6fb6656-9ff6-11e5-946f-f6c9f936c17f.png)

Commits
-------

107c44a CSS min-height and min-width should not be "auto"
@aschempp aschempp deleted the patch-2 branch November 23, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants