Skip to content

[FrameworkBundle] Add APCu support for the Serializer #17025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Dec 16, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This PR configures support for the new APCu class from Doctrine Cache (doctrine/cache#115) for the Serializer service.
I'll open a similar PR for the validator service when #16822 will be merged.

I've opened it against master as a new feature, but maybe must it be merged in older versions (2.3?) and considered as a bug fix: APCu for PHP7 doesn't support the APC API anymore. So Symfony projects migrating to PHP7 will not be able to use metadata cache (mandatory in production) without APCu support or adding manually some services.

@layanto
Copy link

layanto commented Dec 16, 2015

Why is this service named serializer.mapping.cache.apcu instead of serializer.mapping.cache.doctrine.apcu like #16822 ?

@ogizanagi
Copy link
Contributor

@layanto : IMO the serializer.mapping.cache.apcu service id is fine.
The validator.mapping.cache.doctrine.apc was named like this because we were unable to name it validator.mapping.cache.apc as this last one already exists. The doctrine part in it isn't so much important, and short ids are better.

But we won't have any issue to name the new APCu implementation validator.mapping.cache.apcu. So don't worry, it'll stay consistent.

@layanto
Copy link

layanto commented Dec 16, 2015

I too do not like overly long name but I think it is confusing that validator.mapping.cache.apc is deprecated in favour of validator.mapping.cache.doctrine.apc and then this adds validator.mapping.cache.apcu which is very similar to the deprecated name.

@dunglas
Copy link
Member Author

dunglas commented Dec 19, 2015

@layanto APCu migration is a chance to have coherent and short names again.

@fabpot
Copy link
Member

fabpot commented Jan 25, 2016

Closing this one as we should use the new caching component now.

@fabpot fabpot closed this Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants