[2.7] Fixed flatten exception recursion with errors #17052

GrahamCampbell · 2015-12-17T14:49:31Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

Consider the following code:

$error = new ParseError();

$exception = new RuntimeException($error->getMessage(), $error->getCode(), $error);

$flat = new Symfony\Component\Debug\Exception\FlattenException($exception);

Without this fix, that code is broken.

You'll end up with something like this:

FatalThrowableError in FlattenException.php line 76:
Type error: Argument 1 passed to Symfony\Component\Debug\Exception\FlattenException::create() must be an instance of Exception, instance of ParseError given

I came across this error issue in laravel/framework#11329.

stof · 2015-12-17T16:14:23Z

this is not good, as it looses the debugging info.It might be better to wrap it in a FatalThrowableError to be able to continue the flattening

GrahamCampbell · 2015-12-17T16:24:35Z

I'm fine with that if you want me to make that change. I just thought you'd want to separate that behaviour from that class, so I went with skipping.

GrahamCampbell · 2015-12-17T16:28:20Z

How does this look then?

nicolas-grekas · 2015-12-18T17:13:37Z

👍
And if you manage to add a test case I would be +2 :)

GrahamCampbell · 2015-12-18T17:19:30Z

I'll add a couple of tests in a few hours.

nicolas-grekas · 2015-12-22T09:29:51Z

Status: needs work

GrahamCampbell · 2015-12-22T11:26:25Z

Sorry, I'll get to this soon. ;)

GrahamCampbell · 2015-12-22T12:10:39Z

Ping @nicolas-grekas. Not sure what's going on with travis. Looks like it couldn't be arsed to run the tests for some reason?

GrahamCampbell · 2015-12-22T12:17:17Z

Yeh, PHP 5.4 and 5.5 are running no tests for some reason. :/

GrahamCampbell · 2015-12-22T12:18:56Z

This travis issue is affecting the entire code base. For example, one of your PRs didn't get the tests run: #17104.

nicolas-grekas · 2015-12-22T12:24:22Z

5.4 and 5.5 are skipped for PRs so that we get more slots on travis

GrahamCampbell · 2015-12-22T12:24:55Z

Ah, right, so it was intentional. That makes sense. I was just worried that they were getting silently skipped. ;)

GrahamCampbell · 2015-12-22T12:25:46Z

They still waste about 50 seconds of time though each. :(

nicolas-grekas · 2015-12-22T12:31:25Z

Yep... I found no way to be quicker, the slow part is apt-get, which can't be skipped AFAIK

GrahamCampbell · 2015-12-22T13:10:25Z

Test passing now btw. ;)

nicolas-grekas · 2015-12-22T13:12:37Z

👍

GrahamCampbell · 2015-12-26T12:14:24Z

Is this good to merge then? I'm just concious that new symfony releases normally happen around a month after the previous ones, and I'd quite like to have this fix included in the next set of releases.

BTW, Happy Christmas everyone. 🎄

fabpot · 2015-12-26T12:17:36Z

Thank you @GrahamCampbell.

…mCampbell) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #17052). Discussion ---------- [2.7] Fixed flatten exception recursion with errors | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Consider the following code: ```php $error = new ParseError(); $exception = new RuntimeException($error->getMessage(), $error->getCode(), $error); $flat = new Symfony\Component\Debug\Exception\FlattenException($exception); ``` Without this fix, that code is broken. You'll end up with something like this: ``` FatalThrowableError in FlattenException.php line 76: Type error: Argument 1 passed to Symfony\Component\Debug\Exception\FlattenException::create() must be an instance of Exception, instance of ParseError given ``` --- I came across this error issue in laravel/framework#11329. Commits ------- 2b0721d [2.7] Fixed flatten exception recursion with errors

GrahamCampbell · 2015-12-26T12:18:40Z

:)

…s (GrahamCampbell)" This reverts commit af3f4ea, reversing changes made to 021ab8a.

* 2.3: Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"

…th errors (GrahamCampbell)"" This reverts commit e60889a.

* 2.7: [travis] timeout the sigchild tests at 60s CS: Single line comments should use double slashes (//) and not hash (#). Do not use HttpKernel Extension when not needed for 2.7 Do not use HttpKernel Extension when not needed bumped Symfony version to 2.7.9 updated VERSION for 2.7.8 updated CHANGELOG for 2.7.8 bumped Symfony version to 2.3.37 updated VERSION for 2.3.36 update CONTRIBUTORS for 2.3.36 updated CHANGELOG for 2.3.36 Revert "Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"" Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)" use nowdoc instead of heredoc Conflicts: src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/Security/Acl/Dbal/AclProvider.php src/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.php

* 2.8: [travis] timeout the sigchild tests at 60s CS: Single line comments should use double slashes (//) and not hash (#). Do not use HttpKernel Extension when not needed for 2.7 Do not use HttpKernel Extension when not needed bumped Symfony version to 2.8.2 updated VERSION for 2.8.1 updated CHANGELOG for 2.8.1 bumped Symfony version to 2.7.9 updated VERSION for 2.7.8 updated CHANGELOG for 2.7.8 bumped Symfony version to 2.3.37 updated VERSION for 2.3.36 update CONTRIBUTORS for 2.3.36 updated CHANGELOG for 2.3.36 Revert "Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"" Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)" use nowdoc instead of heredoc Conflicts: CHANGELOG-2.3.md CHANGELOG-2.7.md CHANGELOG-2.8.md src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php src/Symfony/Bundle/WebProfilerBundle/Command/ExportCommand.php src/Symfony/Bundle/WebProfilerBundle/Command/ImportCommand.php src/Symfony/Component/Console/Shell.php src/Symfony/Component/Console/Tests/Helper/LegacyTableHelperTest.php src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/HttpKernel/Kernel.php

* 3.0: [travis] timeout the sigchild tests at 60s CS: Single line comments should use double slashes (//) and not hash (#). Do not use HttpKernel Extension when not needed for 2.7 bumped Symfony version to 3.0.2 Do not use HttpKernel Extension when not needed updated VERSION for 3.0.1 updated CHANGELOG for 3.0.1 bumped Symfony version to 2.8.2 updated VERSION for 2.8.1 updated CHANGELOG for 2.8.1 bumped Symfony version to 2.7.9 updated VERSION for 2.7.8 updated CHANGELOG for 2.7.8 bumped Symfony version to 2.3.37 updated VERSION for 2.3.36 update CONTRIBUTORS for 2.3.36 updated CHANGELOG for 2.3.36 Revert "Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"" Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)" use nowdoc instead of heredoc Conflicts: src/Symfony/Component/HttpKernel/Kernel.php

* 2.7: [travis] timeout the sigchild tests at 60s CS: Single line comments should use double slashes (//) and not hash (#). Do not use HttpKernel Extension when not needed for 2.7 Do not use HttpKernel Extension when not needed bumped Symfony version to 2.7.9 updated VERSION for 2.7.8 updated CHANGELOG for 2.7.8 bumped Symfony version to 2.3.37 updated VERSION for 2.3.36 update CONTRIBUTORS for 2.3.36 updated CHANGELOG for 2.3.36 Revert "Revert "bug symfony#17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"" Revert "bug symfony#17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)" use nowdoc instead of heredoc Conflicts: src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/Security/Acl/Dbal/AclProvider.php src/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.php

* 2.8: [travis] timeout the sigchild tests at 60s CS: Single line comments should use double slashes (//) and not hash (#). Do not use HttpKernel Extension when not needed for 2.7 Do not use HttpKernel Extension when not needed bumped Symfony version to 2.8.2 updated VERSION for 2.8.1 updated CHANGELOG for 2.8.1 bumped Symfony version to 2.7.9 updated VERSION for 2.7.8 updated CHANGELOG for 2.7.8 bumped Symfony version to 2.3.37 updated VERSION for 2.3.36 update CONTRIBUTORS for 2.3.36 updated CHANGELOG for 2.3.36 Revert "Revert "bug symfony#17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"" Revert "bug symfony#17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)" use nowdoc instead of heredoc Conflicts: CHANGELOG-2.3.md CHANGELOG-2.7.md CHANGELOG-2.8.md src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php src/Symfony/Bundle/WebProfilerBundle/Command/ExportCommand.php src/Symfony/Bundle/WebProfilerBundle/Command/ImportCommand.php src/Symfony/Component/Console/Shell.php src/Symfony/Component/Console/Tests/Helper/LegacyTableHelperTest.php src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/HttpKernel/Kernel.php

* 3.0: [travis] timeout the sigchild tests at 60s CS: Single line comments should use double slashes (//) and not hash (#). Do not use HttpKernel Extension when not needed for 2.7 bumped Symfony version to 3.0.2 Do not use HttpKernel Extension when not needed updated VERSION for 3.0.1 updated CHANGELOG for 3.0.1 bumped Symfony version to 2.8.2 updated VERSION for 2.8.1 updated CHANGELOG for 2.8.1 bumped Symfony version to 2.7.9 updated VERSION for 2.7.8 updated CHANGELOG for 2.7.8 bumped Symfony version to 2.3.37 updated VERSION for 2.3.36 update CONTRIBUTORS for 2.3.36 updated CHANGELOG for 2.3.36 Revert "Revert "bug symfony#17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"" Revert "bug symfony#17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)" use nowdoc instead of heredoc Conflicts: src/Symfony/Component/HttpKernel/Kernel.php

carsonbot added the Status: Needs Review label Dec 17, 2015

GrahamCampbell mentioned this pull request Dec 17, 2015

ParseError in PHP 7 results in FatalThrowableError laravel/framework#11329

Closed

carsonbot added Status: Needs Work and removed Status: Needs Review labels Dec 22, 2015

nicolas-grekas added the Bug label Dec 22, 2015

GrahamCampbell added 2 commits December 22, 2015 11:55

Fixed flatten exception recursion with errors

9b2cd04

Wrap throwables in a FatalThrowableError

2ada7d0

Added PHP 7 specific test for previous parse errors

7be6188

Fixed typo

7c98c83

nicolas-grekas added Status: Reviewed and removed Status: Needs Work labels Dec 22, 2015

fabpot closed this Dec 26, 2015

GrahamCampbell deleted the 2.7-throwable branch December 26, 2015 12:18

fabpot added a commit that referenced this pull request Dec 26, 2015

Revert "bug #17052 [2.7] Fixed flatten exception recursion with error…

e60889a

…s (GrahamCampbell)" This reverts commit af3f4ea, reversing changes made to 021ab8a.

fabpot added a commit that referenced this pull request Dec 26, 2015

Merge branch '2.3' into 2.7

3c907ce

* 2.3: Revert "bug #17052 [2.7] Fixed flatten exception recursion with errors (GrahamCampbell)"

fabpot added a commit that referenced this pull request Dec 26, 2015

Revert "Revert "bug #17052 [2.7] Fixed flatten exception recursion wi…

778884a

…th errors (GrahamCampbell)"" This reverts commit e60889a.

This was referenced Dec 26, 2015

Release v2.3.36 #17141

Merged

Release v2.7.8 #17142

Merged

Release v2.8.1 #17143

Merged

Release v3.0.1 #17144

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.7] Fixed flatten exception recursion with errors #17052

[2.7] Fixed flatten exception recursion with errors #17052

GrahamCampbell commented Dec 17, 2015

stof commented Dec 17, 2015

GrahamCampbell commented Dec 17, 2015

GrahamCampbell commented Dec 17, 2015

nicolas-grekas commented Dec 18, 2015

GrahamCampbell commented Dec 18, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 26, 2015

fabpot commented Dec 26, 2015

GrahamCampbell commented Dec 26, 2015

[2.7] Fixed flatten exception recursion with errors #17052

[2.7] Fixed flatten exception recursion with errors #17052

Conversation

GrahamCampbell commented Dec 17, 2015

stof commented Dec 17, 2015

GrahamCampbell commented Dec 17, 2015

GrahamCampbell commented Dec 17, 2015

nicolas-grekas commented Dec 18, 2015

GrahamCampbell commented Dec 18, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 22, 2015

nicolas-grekas commented Dec 22, 2015

GrahamCampbell commented Dec 26, 2015

fabpot commented Dec 26, 2015

GrahamCampbell commented Dec 26, 2015