[Finder] Check PHP version before applying a workaround for a PHP bug #17134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alebo
commented
Dec 24, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | -- |
| License | MIT |
| Doc PR | -- |
| @@ -12,9 +12,9 @@ | |||
| namespace Symfony\Component\Finder\Iterator; | |||
|
|
|||
| /** | |||
| * This iterator just overrides the rewind method in order to correct a PHP bug. | |||
| * This iterator just overrides the rewind method in order to correct a PHP bug, which existed before version 5.5.23. | |||
There was a problem hiding this comment.
https://bugs.php.net/bug.php?id=68557 says
Confirmed fixed under PHP 5.5.22.
There was a problem hiding this comment.
I'd double-checked before making the change. It's not fixed in 5.5.22. Also, the fix is listed only in
http://php.net/ChangeLog-5.php#5.5.23
b067fa2 to
de24c81
Compare
| $iterator = $this; | ||
| while ($iterator instanceof \OuterIterator) { | ||
| $innerIterator = $iterator->getInnerIterator(); | ||
| if (version_compare(PHP_VERSION, '5.5.23', '<') |
There was a problem hiding this comment.
We use the PHP_VERSION_ID constant for this:
if (PHP_VERSION_ID < 50523 || PHP_VERSION_ID >= 50600 && PHP_VERSION_ID < 50607) {
// ...
}dc5cec6 to
4d97385
Compare
|
Thank you @alebo. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
…for a PHP bug (alebo) This PR was squashed before being merged into the 2.3 branch (closes #17134). Discussion ---------- [Finder] Check PHP version before applying a workaround for a PHP bug | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Commits ------- cba206a [Finder] Check PHP version before applying a workaround for a PHP bug
jakzal
added a commit
to jakzal/symfony
that referenced
this pull request
Mar 8, 2016
jakzal
added a commit
to jakzal/symfony
that referenced
this pull request
Mar 9, 2016
fabpot
added a commit
that referenced
this pull request
Mar 9, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [Finder] Partially revert #17134 to fix a regression | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18013 | License | MIT | Doc PR | - Commits ------- ead1824 [Finder] Partially revert #17134 to fix a regression
nicolas-grekas
added a commit
that referenced
this pull request
Mar 10, 2016
* 2.3: [Finder] Partially revert #17134 to fix a regression [HttpKernel] Fix mem usage when stripping the prod container exception when registering bags for started sessions Conflicts: src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/HttpKernel/Kernel.php
nicolas-grekas
added a commit
that referenced
this pull request
Mar 10, 2016
* 2.7: [Finder] Partially revert #17134 to fix a regression [HttpKernel] Fix mem usage when stripping the prod container exception when registering bags for started sessions Conflicts: src/Symfony/Component/Validator/composer.json
nicolas-grekas
added a commit
that referenced
this pull request
Mar 10, 2016
* 2.8: [Finder] Partially revert #17134 to fix a regression [HttpKernel] Fix mem usage when stripping the prod container exception when registering bags for started sessions Conflicts: src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php src/Symfony/Component/Validator/composer.json
nicolas-grekas
added a commit
that referenced
this pull request
Mar 10, 2016
* 3.0: (28 commits) [Console] Fix an autocompletion question helper issue with non-sequentially indexed choices [Process] Fix pipes handling [Finder] Partially revert #17134 to fix a regression Mentioned the deprecation of deep parameters in UPGRADE files [HttpKernel] Fix mem usage when stripping the prod container [Filesystem] Fix false positive in ->remove() [Filesystem] Cleanup/sync with 2.3 [Validator] Fix the locale validator so it treats a locale alias as a valid locale [HttpFoundation] Fix transient test [HttpFoundation] Add a dependency on the mbstring polyfill [2.7] update readme files for new components add readme files where missing [2.8] update readme files for new components fix lowest TwigBridge deps versions reference form type by name on Symfony 2.7 [EventDispatcher] fix syntax error Don't use reflections when possible Don't use reflections when possible [Form] Update form tests after the ICU data update [Intl] Update tests and the number formatter to match behaviour of the intl extension ... Conflicts: src/Symfony/Component/Ldap/README.md src/Symfony/Component/Security/Core/README.md src/Symfony/Component/Security/Csrf/README.md src/Symfony/Component/Security/Http/README.md
Merged
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 3.0: (28 commits) [Console] Fix an autocompletion question helper issue with non-sequentially indexed choices [Process] Fix pipes handling [Finder] Partially revert symfony#17134 to fix a regression Mentioned the deprecation of deep parameters in UPGRADE files [HttpKernel] Fix mem usage when stripping the prod container [Filesystem] Fix false positive in ->remove() [Filesystem] Cleanup/sync with 2.3 [Validator] Fix the locale validator so it treats a locale alias as a valid locale [HttpFoundation] Fix transient test [HttpFoundation] Add a dependency on the mbstring polyfill [2.7] update readme files for new components add readme files where missing [2.8] update readme files for new components fix lowest TwigBridge deps versions reference form type by name on Symfony 2.7 [EventDispatcher] fix syntax error Don't use reflections when possible Don't use reflections when possible [Form] Update form tests after the ICU data update [Intl] Update tests and the number formatter to match behaviour of the intl extension ... Conflicts: src/Symfony/Component/Ldap/README.md src/Symfony/Component/Security/Core/README.md src/Symfony/Component/Security/Csrf/README.md src/Symfony/Component/Security/Http/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.