Skip to content

[Process] Fix potential race condition leading to transient tests #17177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2015
Merged

[Process] Fix potential race condition leading to transient tests #17177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Process] Fix potential race condition leading to transient tests
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Dec 30, 2015
commit 99fc428bdcbb9d0e6ab9e6487fc458becd200d3a
9 changes: 3 additions & 6 deletions src/Symfony/Component/Process/Process.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,13 +1072,10 @@ private function readPipes($blocking, $close)

$callback = $this->callback;
foreach ($result as $type => $data) {
if (3 === $type) {
$this->fallbackStatus['running'] = false;
if (!isset($this->fallbackStatus['signaled'])) {
$this->fallbackStatus['exitcode'] = (int) $data;
}
} else {
if (3 !== $type) {
$callback($type === self::STDOUT ? self::OUT : self::ERR, $data);
} elseif (!isset($this->fallbackStatus['signaled'])) {
$this->fallbackStatus['exitcode'] = (int) $data;
}
}
}
Expand Down