[FrameworkBundle] Don't log twice with the error handler #17202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas it does not work because kernel.debug is true |
|
@yapro I also changed the |
|
@nicolas-grekas now it work, thank you |
|
I just checkouted this on a 2.8 std-edition: works well in prod and dev (debug on/off) |
61bbcdd to
5926ff2
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jan 13, 2016
…nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Don't log twice with the error handler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16980 | License | MIT | Doc PR | - ping @Tobion @yapro does it work as expected with this patch? Commits ------- 5926ff2 [FrameworkBundle] Don't log twice with the error handler
|
@nicolas-grekas thx you, but why not 2.7 |
|
I didn't check, does the issue exist on 2.7? |
|
@nicolas-grekas yes |
|
@yapro would you like to open the PR on 2.7? |
|
@nicolas-grekas yes, tnx you |
Merged
|
@nicolas-grekas may be you forget? |
|
@yapro I guess @nicolas-grekas meant if you wanted to create the PR. :) But never mind I opened #17433 to backport this to Symfony 2.7. |
fabpot
added a commit
that referenced
this pull request
Jan 19, 2016
…nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Don't log twice with the error handler | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16980, #17202 | License | MIT | Doc PR | Commits ------- 90d493e [FrameworkBundle] Don't log twice with the error handler
|
@xabbuh thx you :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @Tobion @yapro does it work as expected with this patch?