Skip to content

[Form] fixed DateTimeType tests using "date_widget"="choice". #17248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] fixed DateTimeType tests using "date_widget"="choice". #17248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public function testSubmitDateTime()
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'datetime',
));
Expand Down Expand Up @@ -57,6 +58,7 @@ public function testSubmitString()
'view_timezone' => 'UTC',
'input' => 'string',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
));

Expand All @@ -82,6 +84,7 @@ public function testSubmitTimestamp()
'view_timezone' => 'UTC',
'input' => 'timestamp',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
));

Expand All @@ -108,12 +111,13 @@ public function testSubmitWithoutMinutes()
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'datetime',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make this change? Doesn't it change the test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, it's clear after re-reading your PR :) 👍

'with_minutes' => false,
));

$form->setData(new \DateTime('2010-06-02 03:04:05 UTC'));
$form->setData(new \DateTime());

$input = array(
'date' => array(
Expand All @@ -137,12 +141,13 @@ public function testSubmitWithSeconds()
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'datetime',
'with_seconds' => true,
));

$form->setData(new \DateTime('2010-06-02 03:04:05 UTC'));
$form->setData(new \DateTime());

$input = array(
'date' => array(
Expand All @@ -168,6 +173,7 @@ public function testSubmitDifferentTimezones()
'model_timezone' => 'America/New_York',
'view_timezone' => 'Pacific/Tahiti',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'string',
'with_seconds' => true,
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ public function testSubmitFromChoice()
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'widget' => 'choice',
'years' => array(2010),
));

$text = array(
Expand Down