[PhpUnitBridge] Re-enable the garbage collector #17275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did we initially figured that we needed to disable the GC (because https://bugs.php.net/bug.php?id=53976 is still open)? |
|
See #6063
|
17de091 to
478710f
Compare
|
I triggered several builds on travis while re-enabling 5.4 and 5.5 jobs, no segfault so far. |
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2016
…rekas) This PR was merged into the 2.7 branch. Discussion ---------- [PhpUnitBridge] Re-enable the garbage collector | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17268, #11566 | License | MIT | Doc PR | - The bug is fixed in PHP and disabling the gc causes issues elsewhere. Commits ------- 478710f [PhpUnitBridge] Re-enable the garbage collector
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is fixed in PHP and disabling the gc causes issues elsewhere.