[VarDumper] Add flags to allow fine tuning dumps representation #17305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7efc4ad to
e69fe96
Compare
|
|
||
| private $charset; | ||
|
|
||
| /** | ||
| * @param callable|resource|string|null $output A line dumper callable, an opened stream or an output path, defaults to static::$defaultOutput. | ||
| * @param string $charset The default character encoding to use for non-UTF8 strings. | ||
| * @param int $flags A bit field of static::FLAG_* constants to fine tune dumps repreesentation. |
There was a problem hiding this comment.
repreesentation -> representation
056c866 to
ee4f8a9
Compare
|
ping @symfony/deciders |
ee4f8a9 to
c7b5d86
Compare
| @@ -180,6 +180,9 @@ public function dumpString(Cursor $cursor, $str, $bin, $cut) | |||
| $m = count($str) - 1; | |||
| $i = $lineCut = 0; | |||
|
|
|||
| if ($this->flags & self::DUMP_STRING_LENGTH) { | |||
There was a problem hiding this comment.
I would prefer swapping the arguments (imo that's more readable).
c7b5d86 to
a35ceb0
Compare
|
Status: reviewed 👍 |
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 14, 2016
…sentation (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [VarDumper] Add flags to allow fine tuning dumps representation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15856 | License | MIT | Doc PR | - The `DUMP_STRING_LENGTH` behavior has been requested in #15856, the `DUMP_LIGHT_ARRAY` behavior is what should have been done for the VarDumperTestTrait. Anticipated usage is opt-in, by adding `<env name="DUMP_LIGHT_ARRAY" value="1" />` in `phpunit.xml.dist`. Any more flags proposal anyone? Better names maybe? Commits ------- a35ceb0 [VarDumper] Add flags to allow fine tuning dumps representation
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DUMP_STRING_LENGTHbehavior has been requested in #15856,the
DUMP_LIGHT_ARRAYbehavior is what should have been done for the VarDumperTestTrait. Anticipated usage is opt-in, by adding<env name="DUMP_LIGHT_ARRAY" value="1" />inphpunit.xml.dist.Any more flags proposal anyone? Better names maybe?