[Debug] Fixed erroneous deprecation notice for extended Interfaces #17320
Conversation
|
I think this implementation is too specific. It should be solved generically. Something like ignore deprecated interfaces if the parent interface is from the Symfony namespace as well. |
|
@Tobion Updated accordingly. I don't know if this might cause any unwanted side effects. |
|
Lets see what @nicolas-grekas thinks |
|
There is an issue, and I think we should not restrict the fix to --- a/src/Symfony/Component/Debug/DebugClassLoader.php
+++ b/src/Symfony/Component/Debug/DebugClassLoader.php
@@ -200,8 +200,23 @@ class DebugClassLoader
@trigger_error(sprintf('The %s class extends %s that is deprecated %s', $name, $parent->name, self::$deprecated[$parent->name]), E_USER_DEPRECATED);
}
+ $parentInterfaces = array();
+ $deprecatedInterfaces = array();
+ if ($parent) {
+ foreach ($parent->getInterfaceNames() as $interface) {
+ $parentInterfaces[$interface] = 1;
+ }
+ }
foreach ($refl->getInterfaceNames() as $interface) {
- if (isset(self::$deprecated[$interface]) && strncmp($ns, $interface, $len) && !($parent && $parent->implementsInterface($interface))) {
+ if (isset(self::$deprecated[$interface]) && strncmp($ns, $interface, $len)) {
+ $deprecatedInterfaces[] = $interface;
+ }
+ foreach (class_implements($interface) as $interface) {
+ $parentInterfaces[$interface] = 1;
+ }
+ }
+ foreach ($deprecatedInterfaces as $interface) {
+ if (!isset($parentInterfaces[$interface])) {
@trigger_error(sprintf('The %s %s %s that is deprecated %s', $name, $refl->isInterface() ? 'interface extends' : 'class implements', $interface, self::$deprecated[$interface]), E_USER_DEPRECATED);
}
}@peterrehm could you please also squash your PR and fix the commit message (and PR title)? |
|
Needs tests IMO |
|
Can you add a test covering this ? |
|
Not sure yet, working on it. |
|
Just added a test, please have a look at the test. @nicolas-grekas Otherwise all your comments should have been incorporated as well... |
|
|
||
| $this->assertSame($xError, $lastError); | ||
| } | ||
|
|
||
| public function provideDeprecatedSuper() |
There was a problem hiding this comment.
please keep this dataProvider near the test using it instead of inserting your new test between them
|
Thank you @peterrehm. |
…terfaces (peterrehm) This PR was merged into the 2.8 branch. Discussion ---------- [Debug] Fixed erroneous deprecation notice for extended Interfaces | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16643, #16775 | License | MIT | Doc PR | - Replaces #16775. Commits ------- 5f4e968 Fixed erroneous deprecation notice for extended Interfaces
|
So when a user-land interface extends a deprecated symfony interface, there are no deprecation messages anymore? |
|
yes there is, when the user interface is loaded, isn't it? |
|
Ok I just wanted to make sure. |
Replaces #16775.