[Validator] Remove calls to non-existing method #17357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the detailed investigation. LGTM 👍 |
|
👍 |
|
Thank you @paradajozsef. |
fabpot
added a commit
that referenced
this pull request
Jan 14, 2016
…ozsef) This PR was merged into the 3.0 branch. Discussion ---------- [Validator] Remove calls to non-existing method | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR removes some useless code after #16024. **1.** [ConstraintValidator::buildViolation()](https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Validator/ConstraintValidator.php#L64) marked as deprecated in [2.8](https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Validator/ConstraintValidator.php#L64), and has been removed in [3.0](https://github.com/symfony/symfony/blob/3.0/src/Symfony/Component/Validator/ConstraintValidator.php#L51). But all the ```Symfony/Component/Validator/Constraints/*```validators still making calls to this parent method. **2.** Correct me if I'm wrong, but this condition: ```php $this->context instanceof ExecutionContextInterface ``` in the ```Symfony/Component/Validator/Constraints/*``` validators is useless since 3.0, because the ```$context``` can only be ```ExecutionContextInterface```. I guess the porpuse of this condition was, that in 2.8 there was a [legacy interface](https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php#L63) too. And AFAIK, the ```$context``` is [always initialized](https://github.com/symfony/symfony/blob/3.0/src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php#L842) before validation, so no need to check that ```$context``` is whether null or not. **3.** The return value of [ExecutionContextInterface::getViolations()](https://github.com/symfony/symfony/blob/3.0/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php#L239), is in a different namespace, so it should be used. Commits ------- 37fb4e2 Remove calls to non-existing method
Tobion
added a commit
that referenced
this pull request
Jan 16, 2016
This PR was merged into the 3.0 branch. Discussion ---------- Remove remaining calls to non-existing method | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This removes the ```$this->buildViolation``` calls (which is a dead method) from validators in 3.0, as #17357 did. I just found 3 more. I hope it's not a problem, that it's not in 2 separate PR (Doctrine Bridge, Form). But I can split them if I have to. :) Commits ------- d7e3254 [3.0] Remove calls to not-existent method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some useless code after #16024.
1. ConstraintValidator::buildViolation() marked as deprecated in 2.8, and has been removed in 3.0.
But all the
Symfony/Component/Validator/Constraints/*validators still making calls to this parent method.2. Correct me if I'm wrong, but this condition:
in the
Symfony/Component/Validator/Constraints/*validators is useless since 3.0, because the$contextcan only beExecutionContextInterface. I guess the porpuse of this condition was, that in 2.8 there was a legacy interface too.And AFAIK, the
$contextis always initialized before validation, so no need to check that$contextis whether null or not.3. The return value of ExecutionContextInterface::getViolations(), is in a different namespace, so it should be used.