[HttpFoundation][Cookie] Cookie DateTimeInterface fix #17370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ public function __construct($name, $value = null, $expire = 0, $path = '/', $dom | |||
| } | |||
|
|
|||
| // convert expiration time to a Unix timestamp | |||
| if ($expire instanceof \DateTime) { | |||
| if ($expire instanceof \DateTimeInterface) { | |||
There was a problem hiding this comment.
this does not work on PHP 5.3
There was a problem hiding this comment.
instanceof \DateTime || instanceof \DateTimeInterface
|
Closed in favor of #17371 |
|
Well, we could still additionally check for |
| @@ -85,6 +85,14 @@ public function testConstructorWithDateTime() | |||
| $this->assertEquals($expire->format('U'), $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date'); | |||
| } | |||
|
|
|||
| public function testConstructorWithDateTimeImmutable() | |||
There was a problem hiding this comment.
@requires PHP 5.5 annotation
|
👍 Status: Reviewed |
|
Thank you @wildewouter. |
fabpot
added a commit
that referenced
this pull request
Jan 14, 2016
…dewouter) This PR was squashed before being merged into the 2.3 branch (closes #17370). Discussion ---------- [HttpFoundation][Cookie] Cookie DateTimeInterface fix | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I came across an issue with expiration times on cookies. They were not working with DateTimeImmutable but only the DateTime implementation itself. I refactored this to work with the DateTimeInterface. Commits ------- f1f9754 [HttpFoundation][Cookie] Cookie DateTimeInterface fix
Merged
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an issue with expiration times on cookies. They were not working with DateTimeImmutable but only the DateTime implementation itself. I refactored this to work with the DateTimeInterface.