Skip to content

[HttpFoundation] [Cookie] Cookie DateTimeInterface fix #17371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[HttpFoundation] [Cookie] Cookie DateTimeInterface fix #17371

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c55acb
Fixed bug where not the interface DateTimeInterface but only the impl…
wildewouter Jan 14, 2016
5b31e67
Added unit test for the DateImmutable variant
wildewouter Jan 14, 2016
196d8e0
Fixed the documentation for the Cookie constructor
wildewouter Jan 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed bug where not the interface DateTimeInterface but only the impl… 
…ementation DateTime was accepted
  • Loading branch information
@wildewouter
wildewouter committed Jan 14, 2016
commit 0c55acbd1c82dbdee4830e76d2cb16eb8123173f
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Cookie.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function __construct($name, $value = null, $expire = 0, $path = '/', $dom
}

// convert expiration time to a Unix timestamp
if ($expire instanceof \DateTime) {
if ($expire instanceof \DateTimeInterface) {
$expire = $expire->format('U');
} elseif (!is_numeric($expire)) {
$expire = strtotime($expire);
Expand Down