[Form] fixed false value being converted to an empty string in ChoiceArrayList #17372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ArrayList When `false` value is used as a choice value, it is converted to an empty string, which conflicts with the empty value, if the choice is optional. If the choice is not optional, then there may be problems with html validation, since required choice does not allow empty value to be submitted. This patch disables value casting to string, when the choice contains values, that would be converted to an empty string.
|
I am not sure if this is the right fix but we would need a test in any case that ensures we do not break the behaviour again in the future. |
|
Actually, when using Better solution would be then to convert |
|
No problem, I agree with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
falsevalue is used as a choice value, it is converted to an empty string,which conflicts with the empty value, if the choice is optional. If the choice
is not optional, then there may be problems with html validation, since required
choice does not allow empty value to be submitted.
This patch disables value casting to string, if the choices contain
falsevalue.