Fix performance (PHP5) and memory (PHP7) issues when using token_get_all #17377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y manager will not release small buckets to OS automatically
|
LGTM 👍 Status: Reviewed |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 15, 2016
… token_get_all (nicolas-grekas, peteward) This PR was merged into the 2.3 branch. Discussion ---------- Fix performance (PHP5) and memory (PHP7) issues when using token_get_all | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16868 | License | MIT | Doc PR | - Although it's not the case anymore on PHP 7, on PHP 5, `is_array` checks are much slower than `isset` checks. Also from @peteward in #17384: > New PHP7 memory manager will not release small buckets to OS automatically in cases exposed by `token_get_all()`. This function call addition specifically for PHP7 will reclaim this memory to keep the footprint down of long processe > See above ticket and suggested actions by PHP internals team for long-running tasks (https://bugs.php.net/70098) - I think `cache:clear/warmup` on a heavy app justifies this. > We're running on cloud-based hosting platforms under memory limitations (Platform.sh). When memory is exceeded we're into swap and the cache clearing process goes from seconds to minutes for the initial deployment, which really slows our development workflow and also causes holding page delays. Commits ------- e555aad Add gc_mem_caches() call for PHP7 after itoken_get_all() as new memory manager will not release small buckets to OS automatically d1f72d8 Fix perf and mem issue when using token_get_all
Merged
| @@ -81,7 +86,7 @@ public function setPrefix($prefix) | |||
| */ | |||
| protected function normalizeToken($token) | |||
| { | |||
| if (is_array($token)) { | |||
| if (isset($token[1]) && 'b"' !== $token) { | |||
There was a problem hiding this comment.
what is this 'b"' case about?
There was a problem hiding this comment.
a funny special case of the tokenizer, see https://3v4l.org/P4ZNQ
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it's not the case anymore on PHP 7, on PHP 5,
is_arraychecks are much slower thanissetchecks.Also from @peteward in #17384: