Skip to content

[Process] don't populate internal buffer if user closure is supplied #17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

avindra
Copy link

@avindra avindra commented Jan 15, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #17390
License MIT
Doc PR N/A

Requesting a pull to main repo instead of readonly mirror.

@avindra
Copy link
Author

avindra commented Jan 15, 2016

Is there a way to re-run fabbot.io?

@xabbuh
Copy link
Member

xabbuh commented Jan 15, 2016

@avindra fabbot.io should be triggered again when you add commits or change the existing one (meaning you have to do a forced push afterwards).

@avindra
Copy link
Author

avindra commented Jan 15, 2016

Just tweaked some README grammar, and did a force push, now seeing :

AppVeyor was unable to build non-mergeable pull request

😦

@GuilhemN
Copy link
Contributor

@avindra you must rebase your PR on master or recreate it if master is not the branch you wanted to target.

@avindra
Copy link
Author

avindra commented Jan 16, 2016

Done. Please review, thank you.

@romainneutron
Copy link
Contributor

Closed in favor of #17427 and #17423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants