[2.3][Process] Use stream based storage to avoid memory issues #17423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainneutron
commented
Jan 18, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17390 |
| License | MIT |
|
|
||
| if (false === $latest) { | ||
| return ''; | ||
| if ($this->outputDisabled) { |
7663f4a to
1752677
Compare
| @@ -378,7 +378,7 @@ public function getOutput() | |||
|
|
|||
| $this->readPipes(false, '\\' === DIRECTORY_SEPARATOR ? !$this->processInformation['running'] : true); | |||
|
|
|||
| return $this->stdout; | |||
| return (string) stream_get_contents($this->stdout, -1, 0); | |||
There was a problem hiding this comment.
casting to string triggers copy-on-writes, it would be better to use an if here
1752677 to
fa37d36
Compare
|
Comments addressed, PR updated |
fa37d36 to
da73125
Compare
|
I just updated the PR, I reduced the temp stream to 1M at max before switching on fs. I've also changed the streams mode from |
|
👍 |
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Jan 20, 2016
…sues (romainneutron) This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Process] Use stream based storage to avoid memory issues | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17390 | License | MIT Commits ------- da73125 [Process] Use stream based storage to avoid memory issues
fabpot
added a commit
that referenced
this pull request
Jan 20, 2016
…ge (romainneutron) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Process] Update in 2.7 for stream-based output storage | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17390 | License | MIT This PR should be rebased once #17423 has been merged. It contains fixes related to methode `Process::getErrorOutput` and `Process::getOutput` that do not exist in branch 2.3 Commits ------- 2d931f4 [Process] Use stream based storage to avoid memory issues
Merged
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.