[Validator] Add a PSR-6 adapter #17440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jan 19, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | todo |
|
Ok I did not see your PR before I started working on mine ;P Closing mine as this looks very similar 👍 |
| */ | ||
| public function has($class) | ||
| { | ||
| $item = $this->cacheItemPool->getItem($this->escapeClassName($class)); |
There was a problem hiding this comment.
simply use return $this->cacheItemPool->hasItem($this->escapeClassName($class)); ?
There was a problem hiding this comment.
According to the PSR-6, hasItem can in be unreliable:
* Note: This method MAY avoid retrieving the cached value for performance reasons.
* This could result in a race condition with CacheItemInterface::get(). To avoid
* such situation use CacheItemInterface::isHit() instead.
It looks better to me to keep it as is.
There was a problem hiding this comment.
Performance doesn't matter here, the metadata caching occurs at "compile" time.
There was a problem hiding this comment.
|
@dunglas Can you finish this one? |
|
Should be ok now. |
|
Thank you @dunglas. |
| */ | ||
| private function escapeClassName($class) | ||
| { | ||
| return strtr($class, '\\', '_'); |
There was a problem hiding this comment.
we normalized this sort of operations to str_replace before
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Validator] Minor fixes for the PSR-6 adapter | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | todo Follows #17440. Take into account comments of @Tobion. Commits ------- aa60d5b [Validator] Minor fixes for the PSR-6 adapter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.