[FrameworkBundle] Fix upgrade guides concerning erroneous removal of assets helper #17450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Thank you @regularjack. |
fabpot
added a commit
that referenced
this pull request
Jan 19, 2016
…s removal of assets helper (regularjack) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix upgrade guides concerning erroneous removal of assets helper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As mentioned in #17041, the upgrade guides for 2.7 and 3.0 erroneously mention that the `templating.helper.assets` service is removed in 3.0. #17041 cannot fix these issues since it targets 3.0. This PR should only be merged after #17041 since it depends on it. Commits ------- 5abac56 Fix upgrade guides concerning erroneous removal of assets helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #17041, the upgrade guides for 2.7 and 3.0 erroneously mention that the
templating.helper.assetsservice is removed in 3.0. #17041 cannot fix these issues since it targets 3.0.This PR should only be merged after #17041 since it depends on it.