[WIP] [Cache] Allow to chain adapters #17452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the decorator pattern is the wrong way. All adapters must be able to handle it. Like this: https://github.com/php-cache/chain-adapter/blob/master/src/CachePoolChain.php |
|
The chain suits probably better to this case, indeed. |
|
I was thinking that all adapters was extending the abstract class but it's not the case (and it's why this PR is marked as WIP). |
| @@ -109,7 +129,6 @@ function ($deferred, $namespace) { | |||
| public function getItem($key) | |||
| { | |||
| $id = $this->getId($key); | |||
|
|
|||
|
Replaced by #17556. |
| private $decorated; | ||
|
|
||
| /** | ||
| * @var array |
There was a problem hiding this comment.
Same here. Just by looking at the default value, I know this is an array.
There was a problem hiding this comment.
This PR has been replaced by #17556. The new one doesn't include docblocks changes anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to chain adapters (e.g: use the
ArrayAdapterand fallback to theDoctrineAdapter).ArrayAdapterProxyAdapter