Skip to content

Fixed form types in profiler #17455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Fixed form types in profiler #17455

merged 1 commit into from
Jan 20, 2016

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17453
License MIT
Doc PR -

This only affects to Symfony 3.0 and higher.

Before After
form_types_before form_types_after

@fabpot
Copy link
Member

fabpot commented Jan 20, 2016

Don't we have the problem in 2.8?

@javiereguiluz
Copy link
Member Author

No. This is for example the Symfony Demo app (2.8.2):

form_types_2_8

@fabpot
Copy link
Member

fabpot commented Jan 20, 2016

Thank you @javiereguiluz.

@fabpot fabpot merged commit 12d447d into symfony:3.0 Jan 20, 2016
fabpot added a commit that referenced this pull request Jan 20, 2016
This PR was merged into the 3.0 branch.

Discussion
----------

Fixed form types in profiler

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17453
| License       | MIT
| Doc PR        | -

This only affects to Symfony 3.0 and higher.

| Before | After
| --------- | -------
| ![form_types_before](https://cloud.githubusercontent.com/assets/73419/12448020/aa59c134-bf73-11e5-8ce4-205a97c50339.png) | ![form_types_after](https://cloud.githubusercontent.com/assets/73419/12448024/acad1a6c-bf73-11e5-98cc-2d9ba11d1e29.png)

Commits
-------

12d447d Fixed form types in profiler
@fabpot fabpot mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants