Skip to content

Display Ajax requests from newest to oldest in the toolbar #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Display Ajax requests from newest to oldest in the toolbar #17457

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #16831
License MIT
Doc PR -

Before

ajax_before

After

ajax_after

@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2016

👍

@javiereguiluz
Copy link
Member Author

Failing tests seem unrelated:

1) Symfony\Component\Form\Tests\Extension\Core\Type\ChoiceTypeTest::testCustomChoiceTypeDoesNotInheritChoiceLabels
Symfony\Component\Form\Exception\InvalidArgumentException: Could not load type "choice"

2) Symfony\Component\Process\Tests\ProcessTest::testGetEmptyIncrementalOutput
Failed asserting that two strings are identical.

@paradajozsef
Copy link
Contributor

The first failing test has been fixed since then. I don't know about the second one.

@fabpot
Copy link
Member

fabpot commented Jan 23, 2016

Thank you @javiereguiluz.

fabpot added a commit that referenced this pull request Jan 23, 2016
@fabpot
bug #17457 Display Ajax requests from newest to oldest in the toolbar…
fee0435 
… (javiereguiluz)

This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #17457).

Discussion
----------

Display Ajax requests from newest to oldest in the toolbar

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16831
| License       | MIT
| Doc PR        | -

### Before

![ajax_before](https://cloud.githubusercontent.com/assets/73419/12452801/953133ec-bf90-11e5-94d5-1aa76ef580cb.gif)

### After

![ajax_after](https://cloud.githubusercontent.com/assets/73419/12452806/98ce32c0-bf90-11e5-9302-2e9cc5b72848.gif)

Commits
-------

124d150 Display Ajax request from newest to oldest in the toolbar
@fabpot fabpot closed this Jan 23, 2016
@fabpot fabpot mentioned this pull request Feb 3, 2016
Merged
@fabpot fabpot mentioned this pull request Feb 28, 2016
Merged
@stof stof mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @xabbuh @paradajozsef @fabpot @carsonbot